[5.3] Tags: Fix broken aliases in routing #44515
Open
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42208.
Summary of Changes
The tags router currently does not fix incomplete URL parts like other components. Specifically it does not look up the alias for tags which were only references by an ID and didn't have the slug like expected. The code also unifies the IDs to be arrays as expected.
Testing Instructions
Look up the ID of a tag of your choice which isn't directly linked via a menu item. Go into an article of your choosing and insert the following:
Adapt the
&id=5to the ID of your chosen tag.Actual result BEFORE applying this Pull Request
The URL will look something like this: `http://domain.tld/tags-component/all-tags/5.html
Expected result AFTER applying this Pull Request
The URL will look something like this: `http://domain.tld/tags-component/all-tags/lime.html
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed